-
Notifications
You must be signed in to change notification settings - Fork 1.8k
HCIDOCS-75: Add IPI installation workflow information to our document… #94545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@kdrake20: This pull request references HCIDOCS-75 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
🤖 Mon Jul 14 15:46:49 - Prow CI generated the docs preview: |
c0ec060
to
48b8043
Compare
@kdrake20: This pull request references HCIDOCS-75 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, some comments inline.
9ea3827
to
7f4f67d
Compare
/lgtm |
@kdrake20 A few comments. Otherwise LGTM |
/remove-label peer-review-done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments, otherwise LGTM!
Just an FYI though, I did find it a little hard to review this because of several instances where Michael made a good suggestion, and you replied that you updated with the suggestion, but it didn't seem like you pushed that change to this PR. So it made it hard for me to decide what to comment on and what to leave alone. No big deal though!
/remove-label peer-review-done |
@kdrake20: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@kdrake20: This pull request references HCIDOCS-75 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@kdrake20: This pull request references HCIDOCS-75 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise, LGTM!
|
||
When the node is in the manageable state, the _inspection_ phase starts. The inspection phase ensures that the hardware meets the minimum requirements needed for a successful deployment of {product-title}. | ||
|
||
The `install-config.yaml` file details the provisioning network. On the bootstrap VM, the installation program uses PXE to push a live image to every node with the Ironic Python Agent (IPA) loaded. When using virtual media, it connects directly to the BMC of each node to virtually attach the image. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is PXE? Define this acronym on first usage. Same thing with BMC.
|
||
The nodes enter the cleaning state, where each node must clean all the disks before continuing with the configuration. | ||
|
||
Once the cleaning state finishes, the nodes enter the available state and the installation program moves the nodes to the deploying state. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once the cleaning state finishes, the nodes enter the available state and the installation program moves the nodes to the deploying state. | |
After the cleaning state finishes, the nodes enter the available state and the installation program moves the nodes to the deploying state. |
|
||
After the installation program configures the control plane nodes, it moves control from the bootstrap VM to the control plane nodes and deletes the bootstrap VM. | ||
|
||
The Bare Metal Operator continues the deployment of the workers, storage, and infra nodes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Bare Metal Operator continues the deployment of the workers, storage, and infra nodes. | |
The Bare-Metal Operator continues the deployment of the workers, storage, and infra nodes. |
According to RH Supplemental SG, bare metal as an adjective is hyphenated.
Fixes: HCIDOCS-75
For: OCP 4.15+
Preview
Approvals -
/lgtm
: